[XS] Change in coreboot[main]: cpu/intel/car/romstage: Fix false-positive stack corruption

[Shuo Liu (Code Review)]

Attention is currently required from: Patrick Rudolph.

Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85568?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: cpu/intel/car/romstage: Fix false-positive stack corruption
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

File src/cpu/intel/car/romstage.c:

https://review.coreboot.org/c/coreboot/+/85568/comment/1435ea5b_2a1ddb8e?usp... :
PS1, Line 40: 	stack_canary_breakpoint_remove();
The stack canary is enabled in bootblock ahead of time, right? Not sure if it is a good pattern to do stack_canary_breakpoint_remove at end of each phase/block and stack_canary_breakpoint_init at the head of the each phase/block?

https://review.coreboot.org/c/coreboot/+/85568/comment/c7a52678_d19fb004?usp... :
PS1, Line 44: 
Maybe add comments to specify stack canary and stack guard servers different purposes? e.g., the former is for coreboot stack usage and warns at real time, while the latter also covers FSP-M stack usage and provides an afterwards check.