Attention is currently required from: Bora Guvendik, Anil Kumar K, Tim Wawrzynczak, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63750 )
Change subject: soc/intel: Add Raptor Lake device IDs ......................................................................
Patch Set 3:
(7 comments)
File src/include/cpu/intel/cpu_ids.h:
https://review.coreboot.org/c/coreboot/+/63750/comment/230c4d04_c52380d3 PS3, Line 62: 0xb06a2 0xB06A0 is this still a valid `A0` CPUID for RPL ?
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/63750/comment/ab94671d_2890e540 PS3, Line 3078: #define PCI_DID_INTEL_RPL_P_ESPI_0 0x519c : #define PCI_DID_INTEL_RPL_P_ESPI_1 0x519d I could see 0x5180-0x519F are full list of supported eSPI Ids for RPL.
https://review.coreboot.org/c/coreboot/+/63750/comment/d4809bbb_73cb5ac9 PS3, Line 3439: #define PCI_DID_INTEL_RPL_P_PCIE_RP1 0xa74d : #define PCI_DID_INTEL_RPL_P_PCIE_RP2 0xa70d : #define PCI_DID_INTEL_RPL_P_PCIE_RP3 0xa72d I could see different IDs for CPU RPs?
PCIe* RC 060 (x4) G4 S, P, M 0 / 6 / 0 464Dh PCIe* RC 062 (x4) G4 P 0 / 6 / 2 463Dh PCIe* RC 010 G5 S, P 0 / 1 / 0 460Dh
https://review.coreboot.org/c/coreboot/+/63750/comment/420710cb_795bdbd0 PS3, Line 3442: I don't see RPL PCH RPs DIDs here ?
https://review.coreboot.org/c/coreboot/+/63750/comment/92db0e5e_992055e6 PS3, Line 3515: what about SATA DID?
https://review.coreboot.org/c/coreboot/+/63750/comment/042e50bc_37c92fef PS3, Line 3539: PMC as well ?
https://review.coreboot.org/c/coreboot/+/63750/comment/15a5032b_f45afbff PS3, Line 4149: RPL can u use `PCH` name like it's being done for `ADP` line#4143
-
Subrata Banik (Code Review)