Attention is currently required from: Furquan Shaikh.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56759 )
Change subject: mb/*/jslrvp/dedede: Remove hardcoding of BSP APIC ID
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
@Tim, are you suggesting to introduce chipset.cb into jsl, i don't see that in soc directory. […]
True Subrata...we didn't have chipset.cb design in JSL...it's available from TGL onwards.
I have done changes for ADL to move device cpu_cluster into chipset.cb here:
https://review.coreboot.org/c/coreboot/+/56853/1
If we agree, then I'll push patches for TGL too 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I726d70b4ffc35a28a654abbd20c866f1410e1aee
Gerrit-Change-Number: 56759
Gerrit-PatchSet: 4
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 06 Aug 2021 13:44:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment