Change in coreboot[master]: [WIP] sb/intel/lynxpoint: Isolate _HID and _ADR

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38802 )

Change subject: [WIP] sb/intel/lynxpoint: Isolate _HID and _ADR
......................................................................

[WIP] sb/intel/lynxpoint: Isolate _HID and _ADR

That way, newer IASL won't complain about it.

Change-Id: I086730102e68fd709e8d3bbcfa42855ff0a0ab99
Signed-off-by: Angel Pons 
---
M src/southbridge/intel/lynxpoint/acpi/serialio.asl
1 file changed, 32 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/38802/1

diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
index 9323b91..ea0339d 100644
--- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl
+++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
@@ -125,6 +125,10 @@
    // Serial IO DMA Controller
    Name (_HID, "INTL9C60")
    Name (_UID, 1)
+}
+
+Scope (SDMA)
+{
    Name (_ADR, 0x00150000)

// BAR0 is assigned during PCI enumeration and saved into NVS
@@ -163,6 +167,10 @@
    Name (_HID, "INT33C2")
    Name (_CID, "INT33C2")
    Name (_UID, 1)
+}
+
+Scope (I2C0)
+{
    Name (_ADR, 0x00150001)

Name (SSCN, Package () { 432, 507, 30 })
@@ -245,6 +253,10 @@
    Name (_HID, "INT33C3")
    Name (_CID, "INT33C3")
    Name (_UID, 1)
+}
+
+Scope (I2C1)
+{
    Name (_ADR, 0x00150002)

Name (SSCN, Package () { 432, 507, 30 })
@@ -327,6 +339,10 @@
    Name (_HID, "INT33C0")
    Name (_CID, "INT33C0")
    Name (_UID, 1)
+}
+
+Scope (SPI0)
+{
    Name (_ADR, 0x00150003)

// BAR0 is assigned during PCI enumeration and saved into NVS
@@ -365,6 +381,10 @@
    Name (_HID, "INT33C1")
    Name (_CID, "INT33C1")
    Name (_UID, 1)
+}
+
+Scope (SPI1)
+{
    Name (_ADR, 0x00150004)

// BAR0 is assigned during PCI enumeration and saved into NVS
@@ -416,6 +436,10 @@
    Name (_HID, "INT33C4")
    Name (_CID, "INT33C4")
    Name (_UID, 1)
+}
+
+Scope (UAR0)
+{
    Name (_ADR, 0x00150005)

// BAR0 is assigned during PCI enumeration and saved into NVS
@@ -467,6 +491,10 @@
    Name (_HID, "INT33C5")
    Name (_CID, "INT33C5")
    Name (_UID, 1)
+}
+
+Scope (UAR1)
+{
    Name (_ADR, 0x00150006)

// BAR0 is assigned during PCI enumeration and saved into NVS
@@ -505,6 +533,10 @@
    Name (_HID, "INT33C6")
    Name (_CID, "PNP0D40")
    Name (_UID, 1)
+}
+
+Scope (SDIO)
+{
    Name (_ADR, 0x00170000)

// BAR0 is assigned during PCI enumeration and saved into NVS

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38802 )

Change subject: [WIP] sb/intel/lynxpoint: Isolate _HID and _ADR
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38802/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38802/1//COMMIT_MSG@7 
PS1, Line 7: WIP
I said WIP, so don't let it be merged right away.

Also, don't merge it with this tag...

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38802 )

Change subject: [WIP] sb/intel/lynxpoint: Isolate _HID and _ADR
......................................................................

Patch Set 1: Code-Review-1

If you want to silence the warning, please just do so in the
iasl command line. If somebody would fix the warning to be also
printed for this case (seems reasonable to me), this would be
all for naught...

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38802 )

Change subject: [WIP] sb/intel/lynxpoint: Isolate _HID and _ADR
......................................................................

Patch Set 1: Code-Review-1
> Patch Set 1: Code-Review-1
>
> If you want to silence the warning, please just do so in the
> iasl command line. If somebody would fix the warning to be also
> printed for this case (seems reasonable to me), this would be
> all for naught...

Agreed, it's an ugly kludge.

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38802 )

Change subject: [WIP] sb/intel/lynxpoint: Isolate _HID and _ADR
......................................................................

Abandoned

Ew.