Attention is currently required from: Peter Lemenkov, Alexander Couzens, Patrick Rudolph. amersel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: Add Thinkpad W541 ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52659/comment/91de2ab2_0a0edae2 PS5, Line 7: mb/lenovo/w541: update thinkpad w541
Commit message is abit misleading. […]
Done
Patchset:
PS6: Just need to fix the newlines in cmos.layout now.
File src/mainboard/lenovo/w541/Kconfig:
https://review.coreboot.org/c/coreboot/+/52659/comment/06ecf6f9_d5b09a57 PS5, Line 13: #select HAVE_CMOS_DEFAULT
Any issues with providing a default values? Copying over ones from t440p could be straightforward.
No, I just never thought to try it. I've tested it now, it boots fine with default values so I've added the default values.
File src/mainboard/lenovo/w541/cmos.layout:
https://review.coreboot.org/c/coreboot/+/52659/comment/b760351a_ec97c440 PS5, Line 108:
A mostly cosmetic proposal - consider cleaning up this file. […]
Done