Change in ...coreboot[master]: crossgcc: Update CMake to version 3.13.4

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

5 Feb 2019 5 Feb '19

9:04 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31240

Change subject: crossgcc: Update CMake to version 3.13.4 ......................................................................

crossgcc: Update CMake to version 3.13.4

Change-Id: I9fec45429d80500d80cc6b774718ecc91720f3f2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.13.3.tar.gz.cksum A util/crossgcc/sum/cmake-3.13.4.tar.gz.cksum 3 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/31240/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index c19b766..df37ce1 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -60,7 +60,7 @@ # CLANG version number CLANG_VERSION=7.0.1 MAKE_VERSION=4.2.1 -CMAKE_VERSION=3.13.3 +CMAKE_VERSION=3.13.4

# GCC toolchain archive locations # These are sanitized by the jenkins toolchain test builder, so if diff --git a/util/crossgcc/sum/cmake-3.13.3.tar.gz.cksum b/util/crossgcc/sum/cmake-3.13.3.tar.gz.cksum deleted file mode 100644 index 9ebd7f5..0000000 --- a/util/crossgcc/sum/cmake-3.13.3.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -f33558a268a9286d4fa310abbd56efbaf897f6dc tarballs/cmake-3.13.3.tar.gz diff --git a/util/crossgcc/sum/cmake-3.13.4.tar.gz.cksum b/util/crossgcc/sum/cmake-3.13.4.tar.gz.cksum new file mode 100644 index 0000000..4fbcee8 --- /dev/null +++ b/util/crossgcc/sum/cmake-3.13.4.tar.gz.cksum @@ -0,0 +1 @@ +242ac4986ab38ddb06c7bfb7eb950e4c1b1ca770 tarballs/cmake-3.13.4.tar.gz

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Paul Menzel (Code Review)

5 Feb 5 Feb

1:39 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31240 )

Change subject: crossgcc: Update CMake to version 3.13.4 ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fec45429d80500d80cc6b774718ecc91720f3f2 Gerrit-Change-Number: 31240 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 05 Feb 2019 12:39:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

15 Feb 15 Feb

6:48 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31240 )

Change subject: crossgcc: Update CMake to version 3.13.4 ......................................................................

Patch Set 1:

(1 comment)

I'm not sure we need this version update, although it doesn't look like it hurts anything.

Patrick?

https://review.coreboot.org/#/c/31240/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31240/1//COMMIT_MSG@8 PS1, Line 8: Release notes:

The error added by 3.13.3 in cases that neither a source or binary directory is specified has been downgraded to a warning. While this was never intended, documented, nor supported behavior, some projects relied on it. The error has been downgraded to a warning for the remainder of the 3.13.x release series to allow a transition period, but it may become a fatal error again in a later release. Scripts relying on the old behavior can be trivially fixed by specifying the path to the source tree (even if just .) explicitly and continue to work with all versions of CMake.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fec45429d80500d80cc6b774718ecc91720f3f2 Gerrit-Change-Number: 31240 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-Comment-Date: Fri, 15 Feb 2019 17:48:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

16 Feb 16 Feb

8:13 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31240 )

Change subject: crossgcc: Update CMake to version 3.13.4 ......................................................................

Patch Set 1:

...

(1 comment)

I'm not sure we need this version update, although it doesn't look like it hurts anything.

Patrick?

I'm fine to drop this ... in any case, CMake is only needed fot Clang. so let wait and see next Clang release. FYI: 3.14 is in progress (currently 3.14.0-rc2 released)

-- To view, visit https://review.coreboot.org/c/coreboot/+/31240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fec45429d80500d80cc6b774718ecc91720f3f2 Gerrit-Change-Number: 31240 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-Comment-Date: Sat, 16 Feb 2019 19:13:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

15 Mar 15 Mar

9:26 a.m.

New subject: Change in ...coreboot[master]: crossgcc: Update CMake to version 3.14.0

Hello Paul Menzel, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31240

to look at the new patch set (#2).

Change subject: crossgcc: Update CMake to version 3.14.0 ......................................................................

crossgcc: Update CMake to version 3.14.0

Change-Id: I9fec45429d80500d80cc6b774718ecc91720f3f2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.13.3.tar.gz.cksum A util/crossgcc/sum/cmake-3.14.0.tar.gz.cksum 3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/31240/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fec45429d80500d80cc6b774718ecc91720f3f2 Gerrit-Change-Number: 31240 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

9:46 a.m.

New subject: Change in ...coreboot[master]: crossgcc: Update CMake to version 3.14.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31240 )

Change subject: crossgcc: Update CMake to version 3.14.0 ......................................................................

Patch Set 2:

https://cmake.org/cmake/help/v3.14/release/3.13.html#id3 : "The error added by 3.13.3 in cases that neither a source or binary directory is specified has been downgraded to a warning. While this was never intended, documented, nor supported behavior, some projects relied on it. The error has been downgraded to a warning for the remainder of the 3.13.x release series to allow a transition period, but it may become a fatal error again in a later release. Scripts relying on the old behavior can be trivially fixed by specifying the path to the source tree (even if just .) explicitly and continue to work with all versions of CMake."

-- To view, visit https://review.coreboot.org/c/coreboot/+/31240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fec45429d80500d80cc6b774718ecc91720f3f2 Gerrit-Change-Number: 31240 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-Comment-Date: Fri, 15 Mar 2019 08:46:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

22 Mar 22 Mar

10:36 a.m.

New subject: Change in ...coreboot[master]: crossgcc: Update CMake to version 3.14.0

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31240 )

Change subject: crossgcc: Update CMake to version 3.14.0 ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fec45429d80500d80cc6b774718ecc91720f3f2 Gerrit-Change-Number: 31240 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-Comment-Date: Fri, 22 Mar 2019 09:36:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:36 a.m.

New subject: Change in ...coreboot[master]: crossgcc: Update CMake to version 3.14.0

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31240 )

Change subject: crossgcc: Update CMake to version 3.14.0 ......................................................................

crossgcc: Update CMake to version 3.14.0

Change-Id: I9fec45429d80500d80cc6b774718ecc91720f3f2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31240 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.13.3.tar.gz.cksum A util/crossgcc/sum/cmake-3.14.0.tar.gz.cksum 3 files changed, 3 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index c19b766..fe1ffdf 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -60,7 +60,7 @@ # CLANG version number CLANG_VERSION=7.0.1 MAKE_VERSION=4.2.1 -CMAKE_VERSION=3.13.3 +CMAKE_VERSION=3.14.0

# GCC toolchain archive locations # These are sanitized by the jenkins toolchain test builder, so if @@ -81,7 +81,7 @@ CRT_ARCHIVE="https://releases.llvm.org/$%7BCLANG_VERSION%7D/compiler-rt-$%7BCLANG_VERSION..." CTE_ARCHIVE="https://releases.llvm.org/$%7BCLANG_VERSION%7D/clang-tools-extra-$%7BCLANG_V..." MAKE_ARCHIVE="https://ftpmirror.gnu.org/make/make-$%7BMAKE_VERSION%7D.tar.bz2" -CMAKE_ARCHIVE="https://cmake.org/files/v3.13/cmake-$%7BCMAKE_VERSION%7D.tar.gz" +CMAKE_ARCHIVE="https://cmake.org/files/v3.14/cmake-$%7BCMAKE_VERSION%7D.tar.gz"

ALL_ARCHIVES="$GMP_ARCHIVE $MPFR_ARCHIVE $MPC_ARCHIVE \ $GCC_ARCHIVE $BINUTILS_ARCHIVE $GDB_ARCHIVE $IASL_ARCHIVE \ diff --git a/util/crossgcc/sum/cmake-3.13.3.tar.gz.cksum b/util/crossgcc/sum/cmake-3.13.3.tar.gz.cksum deleted file mode 100644 index 9ebd7f5..0000000 --- a/util/crossgcc/sum/cmake-3.13.3.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -f33558a268a9286d4fa310abbd56efbaf897f6dc tarballs/cmake-3.13.3.tar.gz diff --git a/util/crossgcc/sum/cmake-3.14.0.tar.gz.cksum b/util/crossgcc/sum/cmake-3.14.0.tar.gz.cksum new file mode 100644 index 0000000..997b8a0 --- /dev/null +++ b/util/crossgcc/sum/cmake-3.14.0.tar.gz.cksum @@ -0,0 +1 @@ +30e5423245d98ad98f6ee0c5f73c587846b99d6b tarballs/cmake-3.14.0.tar.gz

-- To view, visit https://review.coreboot.org/c/coreboot/+/31240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fec45429d80500d80cc6b774718ecc91720f3f2 Gerrit-Change-Number: 31240 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-MessageType: merged

2073

days inactive

2118

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

HAOUAS Elyes (Code Review)
Martin Roth (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)