Attention is currently required from: Keith Hui, Paul Menzel.
Nico Huber has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/82632?usp=email )
Change subject: sio/nuvoton: Implement a common ramstage ACPI LDN helper ......................................................................
Patch Set 6: Code-Review+1
(2 comments)
Patchset:
PS5:
Maybe rip the aux device part out of pc_keyboard_init(), and when the conditions are right, swap the […]
Sounds like a plan, but I guess I'm out of my depth here. Can't remember having ever programmed anything related to the aux part. If you write a patch, maybe add Patrick Rudolph, IIRC he did some related work on libpayload.
File src/superio/nuvoton/common/common.c:
https://review.coreboot.org/c/coreboot/+/82632/comment/db3581be_28226190?usp... : PS6, Line 79: * Clear case open pin 0 status. Looks like I forgot to ask before. Why would we do this? Doesn't it mean the user can't be informed (e.g. when running an appropriate OS tool)?.
-
Nico Huber (Code Review)