Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Simon Chou, TimLiu-SMCI, Johnny Lin, Christian Walter, Shuming Chu (Shuming), Arthur Heymans.
Jian-Ming Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71967 )
Change subject: soc/intel/xeon_sp/spr: add ACPI code
......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/xeon_sp/spr/romstage.c:
https://review.coreboot.org/c/coreboot/+/71967/comment/ebb38984_56e9c961
PS2, Line 177: 0x3F8;
Have it depend on the port coreboot uses.
SerialIoUartDebugIoBase in FSPM_UPD is used to control the debug message from Intel FSP. The correct configuration is depending on mainboard design. However, the romstage in soc layer only take care of the critical common configuration. The mainboard specific part should be override or further configured by romstage (mainboard_romstage_entry) in mainboard layer.
Please reference the example to mainboard_config_upd in src/mainboard/ocp/deltalake.romstage.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2a9be0222e122ae087b9cc8e1859d257e3411d6
Gerrit-Change-Number: 71967
Gerrit-PatchSet: 13
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: TimLiu-SMCI
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: TimLiu-SMCI
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 02 Feb 2023 03:02:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment