Change in coreboot[master]: libpayload: cbmem_console: Drop loglevel markers from snapshot

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62506 )

Change subject: libpayload: cbmem_console: Drop loglevel markers from snapshot
......................................................................

Patch Set 2:

(1 comment)

File payloads/libpayload/drivers/cbmem_console.c:

https://review.coreboot.org/c/coreboot/+/62506/comment/d61c8906_be5fa5c7 
PS1, Line 120: /* Slight memory corruption may occur between reboots and give us a few
             : 	   unprintable characters like '\0'. Replace them with '?' on output. */
             : 	for (cursor = 0; cursor < size; cursor++)
             : 		if (!isprint(console_c[cursor]) && !isspace(console_c[cursor]))
             : 			console_c[cursor] = '?';
> > For that to take effect we just need to remove the code block here. […]

Sorry, I'm not sure if this patch was actually meant to go in now or not. But I guess until there's depthcharge code to take advantage of the markers it doesn't really matter anyway?

Maybe the right move forward, if anyone ever wants to add that support to depthcharge, would be to add an argument to this function (bool keep_markers)... and then that decides whether the markers are passed through in the clear or not, and then depthcharge could set that while other payloads that maybe don't want to do this interpretation would still have the option of just getting a pure text log.