Attention is currently required from: Furquan Shaikh, Martin Roth, Marshall Dawson, Subrata Banik, Andrey Petrov, Patrick Rudolph, Nathaniel L Desimone. Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56190 )
Change subject: src/drivers/intel/fsp2_0: allow larger FSP 2.0 header ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/intel/fsp2_0/include/fsp/info_header.h:
https://review.coreboot.org/c/coreboot/+/56190/comment/a6a39ac8_4c8b047f PS2, Line 13: however, some FSP 2.0 variants have it as well.
Thanks for the pointers Nick. […]
Re: less desirable approach. In general, overriding any files in edk2 is considered to be a bad practice that we try to avoid it. In essence, we would have to copy our version of the IntelFsp2Pkg/Include/Guid/FspHeaderFile.h over the one in edk2 directory prior to FSP build. We also don't have support for it in the current build infrastructure. If we do implement override, we end up with a custom non-portable AMD solution that would have to be replicated for other vendors. We could assign a custom revision to the FSP header version and check for it in coreboot but since we don't have the authority over issuance of FSP header revisions we will likely run into revision collisions. Another option is to simply forgo sanity checking of the header length (which is what I believe is being done in looks_like_fsp_header()).
-
Nikolai Vyssotski (Code Review)