Attention is currently required from: Krishna P Bhat D, Rizwan Qureshi, Sridhar Siricilla.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76918?usp=email )
Change subject: soc/intel/common: Modify incorrect return value ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76918/comment/831b4b91_8908df16 : PS1, Line 7: Modify incorrect return value Please be more specific. For example:
Return CB_ERR when cse_data_clear_request() fails
https://review.coreboot.org/c/coreboot/+/76918/comment/1e3330a5_4d879042 : PS1, Line 10: cse_data_clear_request fails. It was modified to CB_SUCCESS in this
`Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit ad6d3128f87c ("soc/intel/common: Use enum cb_err values")'`
Please fix.
https://review.coreboot.org/c/coreboot/+/76918/comment/5e38d3bf_d0802418 : PS1, Line 12: Please add a TEST= line.