Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Martin Roth, Paul Menzel, Tim Van Patten.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75583?usp=email )
Change subject: mb/google/myst: Add PCIe shutdown workaround
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75583/comment/5dc47b7a_9cd098ff :
PS3, Line 9: FSP
Add a version in case FSP gets fixed in the future?
Early bringup, I don't have a version
File src/mainboard/google/myst/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/75583/comment/e27f2f98_dd3b2b7e :
PS2, Line 56: .turn_off_unused_lanes = true,
What are the differences between the two in terms of unintended side effects? My preference would be […]
It's a workaround. We're merging this to get through functional testing. The workaround works.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75583?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf0aca329f05f15a3ce9edfa6a0e782c2edccabe
Gerrit-Change-Number: 75583
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 02 Jun 2023 13:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment