Attention is currently required from: Jakub Czapiga.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68923 )
Change subject: acpigen: Always inline helper functions
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68923/comment/7a713a18_ceb68fd5
PS3, Line 12: normally
I am no compiler expert, but aren’t todays compilers do pretty unexpected choices regarding these things for performance reasons. No idea if it’s common in coreboot to do this, but my gut feeling says that other ways should be found to work with function instrumentation than this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68923
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf747573940fe5e76199f327f4e5bc32b4f8c470
Gerrit-Change-Number: 68923
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Comment-Date: Sat, 29 Oct 2022 10:10:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment