Attention is currently required from: Paul Menzel.
Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/84397?usp=email )
Change subject: mb/google/brox: Remove psys related implementation ......................................................................
Patch Set 8:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84397/comment/a57284bf_27345dac?usp... : PS5, Line 7: PSys
The code comments spell it Psys?
Done
https://review.coreboot.org/c/coreboot/+/84397/comment/09fd71a1_9aa71422?usp... : PS5, Line 7: Platform(PSys)
Please add a space before the (. […]
Done
https://review.coreboot.org/c/coreboot/+/84397/comment/ae3adf32_97ab6127?usp... : PS5, Line 9: boot.Hence
Please add a space after the dot/period.
Done
https://review.coreboot.org/c/coreboot/+/84397/comment/2f1efd27_66d6a0ba?usp... : PS5, Line 9: PSys is not an optimal solution for no/low battery boot.Hence remove
Why? What problems are there?
I have mentioned the bug id where the problems are discussed in detail (in #58)
https://review.coreboot.org/c/coreboot/+/84397/comment/39dc52b0_393f82ea?usp... : PS5, Line 14: TEST=Build and boot on brox board
How can it be checked, that the situation is better now?
please refer to comment 64 and 65 in the bug