Attention is currently required from: Felix Singer, Nicholas Chin.
Ronald Claveau has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email )
Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
......................................................................
Patch Set 16:
(2 comments)
File src/mainboard/dell/xps_8300/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/83104/comment/66ccbf0f_032cf181?usp... :
PS15, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Should be CC-PDDC as per commit cf4722d317ea (src/mb: Update unlicensable files with the CC-PDDC SPD […]
Nice catch, fixed now
File src/mainboard/dell/xps_8300/board.fmd:
PS15:
Just stumbled upon this. […]
Ok with SeaBIOS, I 'll try again with EDK2 later and adjust if needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83104?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059
Gerrit-Change-Number: 83104
Gerrit-PatchSet: 16
Gerrit-Owner: Ronald Claveau
sousmangoosta@aliel.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Tue, 09 Jul 2024 09:20:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com