Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Elyes Haouas, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68548 )
Change subject: soc/amd/*/smi.h: Use BIT() for clarity
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/stoneyridge/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/68548/comment/edd03688_1e117841
PS1, Line 152: BIT
needs <types. […]
Done - good catch, thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I490f0093d55813260fcdb7303a94accfa90e75e4
Gerrit-Change-Number: 68548
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 20 Oct 2022 19:41:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment