Attention is currently required from: Bora Guvendik, Felix Singer, Karthik Ramasubramanian, Shelley Chen.
Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80334?usp=email )
Change subject: mb/google/brox: Handle GPI_INT pin lower to GPI_WAKE
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80334/comment/ff26bc48_56abd8cc :
PS2, Line 7: brox
Please always use meaningful topics, e.g. […]
Done
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/80334/comment/b6a8b797_e8dc080c :
PS2, Line 343: PAD_IRQ_ROUTE(SWAPPED), \
can we push this to the next line? This causes the line to go over the line limit (96 characters). […]
Done
https://review.coreboot.org/c/coreboot/+/80334/comment/706a9f39_a7ab3595 :
PS2, Line 355: PAD_IRQ_ROUTE(SWAPPED), \
Same here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80334?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8c3d557e888b8d0ceac203f49b702910fba26d6d
Gerrit-Change-Number: 80334
Gerrit-PatchSet: 2
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 07 Feb 2024 03:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment