Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36789 )
Change subject: sb/intel/i82801dx,ix: Replace SMM_ASEG conditional ......................................................................
sb/intel/i82801dx,ix: Replace SMM_ASEG conditional
PARALLEL_MP path also calls smm_lock().
Change-Id: I270fc8266d118cd1e7245ea70b707a03aedac209 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/southbridge/intel/i82801dx/lpc.c M src/southbridge/intel/i82801ix/lpc.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/36789/1
diff --git a/src/southbridge/intel/i82801dx/lpc.c b/src/southbridge/intel/i82801dx/lpc.c index 031a01a..a46f5a3 100644 --- a/src/southbridge/intel/i82801dx/lpc.c +++ b/src/southbridge/intel/i82801dx/lpc.c @@ -304,7 +304,7 @@ /* Don't allow evil boot loaders, kernels, or * userspace applications to deceive us: */ - if (CONFIG(HAVE_SMI_HANDLER)) + if (CONFIG(HAVE_SMI_HANDLER) && !CONFIG(PARALLEL_MP)) aseg_smm_lock(); }
diff --git a/src/southbridge/intel/i82801ix/lpc.c b/src/southbridge/intel/i82801ix/lpc.c index 16763bc..3df9288 100644 --- a/src/southbridge/intel/i82801ix/lpc.c +++ b/src/southbridge/intel/i82801ix/lpc.c @@ -423,7 +423,7 @@ /* Don't allow evil boot loaders, kernels, or * userspace applications to deceive us: */ - if (CONFIG(HAVE_SMI_HANDLER) && CONFIG(SMM_ASEG)) + if (CONFIG(HAVE_SMI_HANDLER) && !CONFIG(PARALLEL_MP)) aseg_smm_lock(); }
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36789 )
Change subject: sb/intel/i82801dx,ix: Replace SMM_ASEG conditional ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36789 )
Change subject: sb/intel/i82801dx,ix: Replace SMM_ASEG conditional ......................................................................
sb/intel/i82801dx,ix: Replace SMM_ASEG conditional
PARALLEL_MP path also calls smm_lock().
Change-Id: I270fc8266d118cd1e7245ea70b707a03aedac209 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36789 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/i82801dx/lpc.c M src/southbridge/intel/i82801ix/lpc.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/southbridge/intel/i82801dx/lpc.c b/src/southbridge/intel/i82801dx/lpc.c index 031a01a..a46f5a3 100644 --- a/src/southbridge/intel/i82801dx/lpc.c +++ b/src/southbridge/intel/i82801dx/lpc.c @@ -304,7 +304,7 @@ /* Don't allow evil boot loaders, kernels, or * userspace applications to deceive us: */ - if (CONFIG(HAVE_SMI_HANDLER)) + if (CONFIG(HAVE_SMI_HANDLER) && !CONFIG(PARALLEL_MP)) aseg_smm_lock(); }
diff --git a/src/southbridge/intel/i82801ix/lpc.c b/src/southbridge/intel/i82801ix/lpc.c index 16763bc..3df9288 100644 --- a/src/southbridge/intel/i82801ix/lpc.c +++ b/src/southbridge/intel/i82801ix/lpc.c @@ -423,7 +423,7 @@ /* Don't allow evil boot loaders, kernels, or * userspace applications to deceive us: */ - if (CONFIG(HAVE_SMI_HANDLER) && CONFIG(SMM_ASEG)) + if (CONFIG(HAVE_SMI_HANDLER) && !CONFIG(PARALLEL_MP)) aseg_smm_lock(); }
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)