Change in ...coreboot[master]: mb/siemens/mc_apl1: use comment in Kconfig.name

[Thomas Heijligen (Code Review)]

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31969

Change subject: mb/siemens/mc_apl1: use comment in Kconfig.name
......................................................................

mb/siemens/mc_apl1: use comment in Kconfig.name

Change-Id: I3c8791a0ed7b3bc670cf1433fa58f9b3d68e0b97
Signed-off-by: Thomas Heijligen 
---
M src/mainboard/siemens/mc_apl1/Kconfig.name
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/31969/1

diff --git a/src/mainboard/siemens/mc_apl1/Kconfig.name b/src/mainboard/siemens/mc_apl1/Kconfig.name
index 3a5b6a3..cae6ac1 100644
--- a/src/mainboard/siemens/mc_apl1/Kconfig.name
+++ b/src/mainboard/siemens/mc_apl1/Kconfig.name
@@ -1,3 +1,5 @@
+comment "MC APLx"
+
 config BOARD_SIEMENS_MC_APL1
    bool "-> MC APL1"
    select BOARD_SIEMENS_BASEBOARD_MC_APL1

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31969 )

Change subject: mb/siemens/mc_apl1: use comment in Kconfig.name
......................................................................

Patch Set 1:

Can you please provide me more details about the background of this change?

[Thomas Heijligen (Code Review)]

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31969 )

Change subject: mb/siemens/mc_apl1: use comment in Kconfig.name
......................................................................

Patch Set 1:
> Patch Set 1:
>
> Can you please provide me more details about the background of this change?

When adding an other group of mainboards the variant selection gets confusing.
Other vendors doing the same.
It should be:
  *** Baseboard 1 ***
      -> Variant A
      -> Variant B
  *** Baseboard 2 ***
      -> Variant A
      -> Variant B
      Board 3
      Board 4

instead of
      -> Variant A
      -> Variant B
      -> Variant A
      -> Variant B
      Board 3
      Board 4

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31969 )

Change subject: mb/siemens/mc_apl1: use comment in Kconfig.name
......................................................................

Patch Set 1: Code-Review+2

[Uwe Poeche (Code Review)]

Uwe Poeche has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31969 )

Change subject: mb/siemens/mc_apl1: use comment in Kconfig.name
......................................................................

Patch Set 1: Code-Review+1

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31969 )

Change subject: mb/siemens/mc_apl1: use comment in Kconfig.name
......................................................................

Patch Set 1:

will you add other group ?

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31969 )

Change subject: mb/siemens/mc_apl1: use comment in Kconfig.name
......................................................................

Patch Set 1: Code-Review+1

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31969 )

Change subject: mb/siemens/mc_apl1: use comment in Kconfig.name
......................................................................

Patch Set 1: Code-Review+2
> Patch Set 1:
>
> will you add other group ?

Not for the other two boards (mc_tcu3 and mc_bdx1).
We will keep this in mind for future platforms/mainboards.

[Werner Zeh (Code Review)]

Werner Zeh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31969 )

Change subject: mb/siemens/mc_apl1: use comment in Kconfig.name
......................................................................

mb/siemens/mc_apl1: use comment in Kconfig.name

Change-Id: I3c8791a0ed7b3bc670cf1433fa58f9b3d68e0b97
Signed-off-by: Thomas Heijligen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31969
Tested-by: build bot (Jenkins) 
Reviewed-by: Mario Scheithauer 
Reviewed-by: Uwe Poeche 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Werner Zeh 
---
M src/mainboard/siemens/mc_apl1/Kconfig.name
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Werner Zeh: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, but someone else must approve
  Mario Scheithauer: Looks good to me, approved
  Uwe Poeche: Looks good to me, but someone else must approve

diff --git a/src/mainboard/siemens/mc_apl1/Kconfig.name b/src/mainboard/siemens/mc_apl1/Kconfig.name
index 3a5b6a3..cae6ac1 100644
--- a/src/mainboard/siemens/mc_apl1/Kconfig.name
+++ b/src/mainboard/siemens/mc_apl1/Kconfig.name
@@ -1,3 +1,5 @@
+comment "MC APLx"
+
 config BOARD_SIEMENS_MC_APL1
    bool "-> MC APL1"
    select BOARD_SIEMENS_BASEBOARD_MC_APL1

[Thomas Heijligen (Code Review)]

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31969 )

Change subject: mb/siemens/mc_apl1: use comment in Kconfig.name
......................................................................

Patch Set 2:
> Patch Set 1: Code-Review+2
> > Patch Set 1:
> >
> > will you add other group ?
>
> Not for the other two boards (mc_tcu3 and mc_bdx1).
> We will keep this in mind for future platforms/mainboards.

We will add a group with at least 2 board variants manufactured by Siemens. But the code is not working yet.