Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58235 )
Change subject: mb/intel/adlrvp: Remove EC region
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
We need EC region in order to boot the Windows SKU and for Chrome SKU as this path is bypass for on-board EC, I don't expect to see any issue with EC region still there in ChromeOS.fmd.
Now as this CL removes EC region, we might not be able to create unified image that can still boot both Windows and Chrome SKU RVPs without any changes.
Any reason, why do had to remove this ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic76c29069beb510dd7620f340e0aab212668c3f3
Gerrit-Change-Number: 58235
Gerrit-PatchSet: 2
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: AndreX Andraos
andrex.andraos@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 25 Oct 2021 05:12:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment