Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kyle Lin, Nick Vaccaro, Subrata Banik, Yunlong Jia.
Kapil Porwal has posted comments on this change by Yunlong Jia. ( https://review.coreboot.org/c/coreboot/+/85512?usp=email )
Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and touchpanel
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85512/comment/83eaaa05_c1222e2c?usp... :
PS2, Line 9: We cannot add a dedicated DB_HDMI field item, so reuse DB_A_HDMI_LTE \
: (old name:DB_A) as the HDMI switch.
: We cannot modify the TOUCH_PANEL field item according to the screen model.
: Type-C and HDMI use the same interface in hardware,\
: so turn off the Type-C setting when using HDMI, \
: And use TOUCH_PANEL_I2C_GENERIC to open another screen model.
Please format this message with 72 chars as maximum line width and remove ``.
https://review.coreboot.org/c/coreboot/+/85512/comment/aacb2568_a6c384a4?usp... :
PS2, Line 29: Change
`No Signed-off-by line in commit message`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85512?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1900658f7c2e09180287a4e61f02e04be203b6e9
Gerrit-Change-Number: 85512
Gerrit-PatchSet: 2
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jiping He
jiping.he@ecs.corp-partner.google.com
Gerrit-CC: Kyle Lin
kylelinck@google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kyle Lin
kylelinck@google.com
Gerrit-Attention: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 16 Dec 2024 05:25:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No