Attention is currently required from: Hung-Te Lin, Paul Menzel, Angel Pons, Yu-Ping Wu. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62933 )
Change subject: soc/mediatek: Add timestamp to measure PERST# time ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62933/comment/3a93e82a_3f1c9e6e PS1, Line 10:
Also paste the new log messages?
Done
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62933/comment/addf3c78_728ee623 PS1, Line 238: COLLECT_TIMESTAMPS
If we just need one timer, what about using timer_monotonic_get , sowe don't need COLLECT_TIMESTAMPS […]
Done
https://review.coreboot.org/c/coreboot/+/62933/comment/5131c8b2_62f60448 PS1, Line 239: pre_timestamp, cur_timestamp, perst_time
Append unit us to the name, or is that clear? For example `perst_time_us`.
Done
https://review.coreboot.org/c/coreboot/+/62933/comment/6f0a99f8_947c49d7 PS1, Line 245: [%lld]
Brackets not needed?
Done
https://review.coreboot.org/c/coreboot/+/62933/comment/73058505_cfcc0d36 PS1, Line 255: [%lld]
Ditto.
Done
-
Jianjun Wang (Code Review)