Attention is currently required from: Felix Singer, Kyösti Mälkki, Lance Zhao, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76008?usp=email )
Change subject: acpi/acpi.c: Split of ACPI table generation into separate files
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76008/comment/1956fb77_02a3ef3f :
PS1, Line 213: #if ENV_X86
We already have some arch/x86/acpi*.c and SMBIOS split was done by leaving x86 stuff under arch/x86 instead of bringing them in lib/ and have ARCH_X86 preprocessor. If you do not expect that these new files have uses outside x86 I am not sure why they should stay in acpi/ instead of arch/x86.
I was thinking about that too. Is it weird to have a whole dir dedicated to acpi but then move parts of that to arch ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76008?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5083b26c0d4cc6764b4e3cb0ff586797cae7e3af
Gerrit-Change-Number: 76008
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 23 Jun 2023 15:01:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment