Michał Żygowski has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62209 )
Change subject: mb/dell/optiplex_9010: Fix chassis types ......................................................................
mb/dell/optiplex_9010: Fix chassis types
Discovered this chassis identification number on Dell Precision T1650 which is much OptiPlex 9010 alike. Precision T1650 is a Mid Tower (MT) chassis.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I2266fe39606b947a3d30a9462377fd56c39c2fa7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62209 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/dell/optiplex_9010/mainboard.c M src/mainboard/dell/optiplex_9010/sch5545_ec.c 2 files changed, 2 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/dell/optiplex_9010/mainboard.c b/src/mainboard/dell/optiplex_9010/mainboard.c index 8a619c0..25f9196 100644 --- a/src/mainboard/dell/optiplex_9010/mainboard.c +++ b/src/mainboard/dell/optiplex_9010/mainboard.c @@ -64,16 +64,13 @@ printk(BIOS_DEBUG, "Chassis type: "); switch (pin_sts) { case 0: + case 4: printk(BIOS_DEBUG, "MT\n"); break; case 3: case 11: printk(BIOS_DEBUG, "USFF\n"); break; - case 4: - /* As per table in schematics, but don't know what this is */ - printk(BIOS_DEBUG, "Comoros\n"); - break; case 1: case 9: case 5: diff --git a/src/mainboard/dell/optiplex_9010/sch5545_ec.c b/src/mainboard/dell/optiplex_9010/sch5545_ec.c index 60cde7d..fa78a98 100644 --- a/src/mainboard/dell/optiplex_9010/sch5545_ec.c +++ b/src/mainboard/dell/optiplex_9010/sch5545_ec.c @@ -547,6 +547,7 @@ /* This mapping will determine which EC init sequence to use */ switch (chassis_id) { case 0x0: + case 0x4: return 5; case 0x8: return 4;