Change in coreboot[master]: soc/amd/cezanne: Turn off gpp clock request for disabled devices

Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61259 to look at the new patch set (#12). Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices ...................................................................... soc/amd/cezanne: Turn off gpp clock request for disabled devices The current behavior does not actually check if a device is present before enabling the corresponding gpp_clkx_clock_request_mapping bits which may cause issues with L1SS. This change sets the corresponding gpp_clkx_clock_request_mapping to off if the corresponding device is disabled. BUG=b:202252869 TEST=Checked that value of GPP_CLK_CNTRL matched the expected value when devices are enabled/disabled FIXED=b:202252869 Signed-off-by: Robert Zieba <robertzieba@google.com> Change-Id: I77389372c60bdec572622a3b49484d4789fd4e4c --- M src/mainboard/google/guybrush/Makefile.inc M src/soc/amd/cezanne/Makefile.inc M src/soc/amd/cezanne/chip.h M src/soc/amd/cezanne/fch.c A src/soc/amd/cezanne/platform_descriptors.c 5 files changed, 94 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/61259/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/61259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77389372c60bdec572622a3b49484d4789fd4e4c Gerrit-Change-Number: 61259 Gerrit-PatchSet: 12 Gerrit-Owner: Robert Zieba <robertzieba@google.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Eric Peers <epeers@google.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Robert Zieba <robertzieba@google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Attention: Rob Barnes <robbarnes@google.com> Gerrit-MessageType: newpatchset
participants (1)
-
Robert Zieba (Code Review)