Change in coreboot[master]: util/docker/coreboot-sdk: Add packages required to build LinuxBoot

[Wim Vervoorn (Code Review)]

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38751 )

Change subject: util/docker/coreboot-sdk: Add packages required to build LinuxBoot
......................................................................

util/docker/coreboot-sdk: Add packages required to build LinuxBoot

Add golang and libelf-dev so LinuxBoot can be built from the
coreboot-sdk docker container.

BUG=N/A
TEST=build

Change-Id: I7a156fc24a6040d73467e06c16139bf298a29740
Signed-off-by: Wim Vervoorn 
---
M util/docker/coreboot-sdk/Dockerfile
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38751/1

diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile
index 2e8fe38..7c87056 100644
--- a/util/docker/coreboot-sdk/Dockerfile
+++ b/util/docker/coreboot-sdk/Dockerfile
@@ -35,10 +35,12 @@
    	gcc \
    	git \
    	gnat \
+		golang \
    	graphviz \
    	libcrypto++-dev \
    	libcurl4 \
    	libcurl4-openssl-dev \
+		libelf-dev \
    	libfreetype6-dev \
    	libftdi-dev \
    	libftdi1-dev \

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38751 )

Change subject: util/docker/coreboot-sdk: Add packages required to build LinuxBoot
......................................................................

Patch Set 2: Verified+1 Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38751 )

Change subject: util/docker/coreboot-sdk: Add packages required to build LinuxBoot
......................................................................

util/docker/coreboot-sdk: Add packages required to build LinuxBoot

Add golang and libelf-dev so LinuxBoot can be built from the
coreboot-sdk docker container.

BUG=N/A
TEST=build

Change-Id: I7a156fc24a6040d73467e06c16139bf298a29740
Signed-off-by: Wim Vervoorn 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38751
Tested-by: Martin Roth 
Reviewed-by: Martin Roth 
---
M util/docker/coreboot-sdk/Dockerfile
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Martin Roth: Verified; Looks good to me, approved

diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile
index 2e8fe38..7c87056 100644
--- a/util/docker/coreboot-sdk/Dockerfile
+++ b/util/docker/coreboot-sdk/Dockerfile
@@ -35,10 +35,12 @@
    	gcc \
    	git \
    	gnat \
+		golang \
    	graphviz \
    	libcrypto++-dev \
    	libcurl4 \
    	libcurl4-openssl-dev \
+		libelf-dev \
    	libfreetype6-dev \
    	libftdi-dev \
    	libftdi1-dev \

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38751 )

Change subject: util/docker/coreboot-sdk: Add packages required to build LinuxBoot
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/495
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/494
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/493

Please note: This test is under development and might not be accurate at all!