Change in coreboot[master]: WIP: mediatek/mt8192: spm: Clean/invalidate cache before loading

[Nicolas Boichat (Code Review)]

Nicolas Boichat has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47281 )

Change subject: WIP: mediatek/mt8192: spm: Clean/invalidate cache before loading
......................................................................

WIP: mediatek/mt8192: spm: Clean/invalidate cache before loading

Unclear if necessary (but it might make sense).

BUG=b:172177570
TEST=Asurada boots up to shell, suspend works

Change-Id: I975a23d6ca3dd9c2a68f483dae608d1626c83c2b
Signed-off-by: Nicolas Boichat 
---
M src/soc/mediatek/mt8192/spm.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/47281/1

diff --git a/src/soc/mediatek/mt8192/spm.c b/src/soc/mediatek/mt8192/spm.c
index 5613027..a6f2109 100644
--- a/src/soc/mediatek/mt8192/spm.c
+++ b/src/soc/mediatek/mt8192/spm.c
@@ -1,5 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

+#include <arch/cache.h>
 #include <assert.h>
 #include <cbfs.h>
 #include <console/console.h>
@@ -923,6 +924,9 @@
    u32 dmem_start;
    u32 con0;

+	/* TODO: Unclear if necessary. */
+	dcache_clean_invalidate_all();
+
    ptr = (uintptr_t) spm_firmware_binary + 0x40000000;
    pmem_words = spm_firmware.pmem_words;
    total_words = spm_firmware.total_words;

[Nicolas Boichat (Code Review)]

Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47281 )

Change subject: WIP: mediatek/mt8192: spm: Clean/invalidate cache before loading
......................................................................

Patch Set 1:

(we might want to find a better way to load that SPM firmware in uncached memory)

[Nicolas Boichat (Code Review)]

Nicolas Boichat has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47281 )

Change subject: WIP: mediatek/mt8192: spm: Clean/invalidate cache before loading
......................................................................

Abandoned

Fixed by MTK with a better solution. https://review.coreboot.org/c/coreboot/+/47287/6