Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email )
Change subject: mb/google/rauru: Implement SKU ID ......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/google/rauru/boardid.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/23e04753_ab31fedc?usp... : PS7, Line 38: printk(BIOS_DEBUG, "AUXADC: channel=%u\n", channel); : printk(BIOS_DEBUG, "AUXADC: VIN1=%d VIN2=%d\n", AUXADC_CHAN_VIN1, AUXADC_CHAN_VIN2); These 2 logs don't seem needed.
https://review.coreboot.org/c/coreboot/+/85666/comment/3d19221a_0e3f7135?usp... : PS7, Line 41: printk(BIOS_DEBUG, "AUXADC: value=%d\n", value); Don't need this either. We already print `value` in the other log below.
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/182d9f74_874d3733?usp... : PS7, Line 59: configure_audio(); Need `mt6363_init_pmif_arb`.