Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Krystian Hebel, Sergii Dmytruk.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68748 )
Change subject: security/tpm: add TPM log format as per 2.0 spec ......................................................................
Patch Set 5:
(4 comments)
File src/security/tpm/tpm2_log_serialized.h:
https://review.coreboot.org/c/coreboot/+/68748/comment/d3626099_3da0cc7d PS5, Line 38: struct tpm_2_log_entry { Why aren't these structures in commonlib when the spec_id ones are? Wouldn't e.g. the cbmem utility want to reuse these as well?
File src/security/tpm/tspi/log-tpm2.c:
https://review.coreboot.org/c/coreboot/+/68748/comment/3ec3d530_040a5c35 PS5, Line 77: MAX_TPM_LOG_ENTRIES Is it intentional that these two fields don't get forced to little-endian while the others do? Is guess if they're "vendor" fields you can technically do that, but it seems a bit silly.
https://review.coreboot.org/c/coreboot/+/68748/comment/72abd072_ae263797 PS5, Line 158: strncpy((char *)tce->data, name, sizeof(tce->data) - 1); Same termination issue here.
https://review.coreboot.org/c/coreboot/+/68748/comment/46a362b7_890eaa52 PS5, Line 176: tce->pcr le32toh?