Attention is currently required from: Jason Glenesk, Raul Rangel, EricKY Cheng, Matt DeVillier, Chris Wang, Fred Reitberger, Karthikeyan Ramasubramanian, Felix Held.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68469 )
Change subject: soc/amd/mendocino: Expand extra 5 DPTC thermal related profiles
......................................................................
Patch Set 8:
(2 comments)
File src/soc/amd/mendocino/chip.h:
https://review.coreboot.org/c/coreboot/+/68469/comment/629d522f_f43528e5
PS8, Line 81: uint32_t thermctl_limit_degreeC_B;
Looking at the table in https://b.corp.google.com/issues/232946420#comment116, `Thermctl Limit(APU)` is the same as table A for every case, so it can be removed for the rest of the tables (B/C/etc profile).
https://review.coreboot.org/c/coreboot/+/68469/comment/737b1846_456241d6
PS8, Line 88: uint16_t stt_alpha_apu_B;
: uint16_t stt_error_coeff_B;
: uint16_t stt_error_rate_coefficient_B;
Looking at the table in https://b.corp.google.com/issues/232946420#comment116, these 3 values are the same as table A for every case, so they can be removed for the rest of the tables (B/C/etc profile).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie03de155325cbb340fce09848327ff7fa33ab1fd
Gerrit-Change-Number: 68469
Gerrit-PatchSet: 8
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nelson Ye
nelson_ye@compal.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 26 Oct 2022 21:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment