Change in ...coreboot[master]: [WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-06...

List overview All Threads
Download

newer

older

Change in ...coreboot[master]: Add...

Change in ...coreboot[master]:...

Kevin Chiu (Code Review)

6 Mar 2019 6 Mar '19

12:29 p.m.

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31778

Change subject: [WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................

[WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants

BUG=b:127394249 BRANCH=master TEST=emerge-grunt coreboot chromeos-bootimage Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc A src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16TB-062E-J.spd.hex 2 files changed, 34 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/31778/1

diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc b/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc index e6dc7e6..213fc05 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc +++ b/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc @@ -27,7 +27,7 @@ SPD_SOURCES += hynix-H5AN8G6NCJR-VKC # 0b1000 SPD_SOURCES += samsung-K4A8G165WC-BCTD # 0b1001 SPD_SOURCES += samsung-K4AAG165WB-MCTD # 0b1010 -SPD_SOURCES += empty # 0b1011 +SPD_SOURCES += micron-MT40A512M16TB-062E-J # 0b1011 SPD_SOURCES += empty # 0b1100 SPD_SOURCES += empty # 0b1101 SPD_SOURCES += empty # 0b1110 diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16TB-062E-J.spd.hex b/src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16TB-062E-J.spd.hex new file mode 100644 index 0000000..45caff6 --- /dev/null +++ b/src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16TB-062E-J.spd.hex @@ -0,0 +1,33 @@ +# MT40A512M16TB-062E:J +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 05 0D F8 FF 2B 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 60 5B +0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 2C 00 00 00 00 00 00 00 4D 54 34 30 41 35 31 +32 4D 31 36 54 42 2D 30 36 32 45 3A 4A 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

Attachments:

attachment.htm (text/html — 6.6 KB)

Show replies by date

build bot (Jenkins) (Code Review)

6 Mar 6 Mar

12:30 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31778 )

Change subject: [WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................

Patch Set 1:

(33 comments)

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16TB-062E-J.spd.hex:

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 1: # MT40A512M16TB-062E:J DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 2: 23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 3: 00 00 05 0D F8 FF 2B 00 6E 6E 6E 11 00 6E F0 0A DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 4: 20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 5: 00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 6: 16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 7: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 9: 00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 60 5B DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 10: 0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 11: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 12: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 13: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 14: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 15: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 16: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 17: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 18: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 19: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 21: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 22: 80 2C 00 00 00 00 00 00 00 4D 54 34 30 41 35 31 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 23: 32 4D 31 36 54 42 2D 30 36 32 45 3A 4A 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 24: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 25: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 26: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 27: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 28: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 29: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 31: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 32: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

https://review.coreboot.org/#/c/31778/1/src/mainboard/google/kahlee/variants... PS1, Line 33: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings

-- To view, visit https://review.coreboot.org/c/coreboot/+/31778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Gerrit-Change-Number: 31778 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Mar 2019 03:30:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

12:39 p.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31778

to look at the new patch set (#2).

Change subject: [WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................

[WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/31778/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Gerrit-Change-Number: 31778 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Kevin Chiu (Code Review)

12:44 p.m.

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31778 )

Change subject: [WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31778/2/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc:

https://review.coreboot.org/#/c/31778/2/src/mainboard/google/kahlee/variants... PS2, Line 30: 0b1011 Hi Martin, we'll need your confirmation to define memory ID. thanks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Gerrit-Change-Number: 31778 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Mar 2019 03:44:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

12:54 p.m.

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31778 )

Change subject: [WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................

Patch Set 2: Code-Review-1

waiting for memory ID assignment.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Gerrit-Change-Number: 31778 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Mar 2019 03:54:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

7 Mar 7 Mar

1:39 a.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31778 )

Change subject: [WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/31778/2/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc:

https://review.coreboot.org/#/c/31778/2/src/mainboard/google/kahlee/variants... PS2, Line 30: 0b1011

...

Hi Martin, we'll need your confirmation to define memory ID. thanks.

Hi Kevin, this works for me.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Gerrit-Change-Number: 31778 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Mar 2019 16:39:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-MessageType: comment

Martin Roth (Code Review)

8 Mar 8 Mar

12:57 a.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31778 )

Change subject: [WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................

Patch Set 2:

Hi Kevin, If you want to remove the -1 and WIP from the commit message, I'll get this merged.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Gerrit-Change-Number: 31778 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 07 Mar 2019 15:57:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

1:31 a.m.

New subject: Change in ...coreboot[master]: mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J S...

Hello build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31778

to look at the new patch set (#3).

Change subject: mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................

mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/31778/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Gerrit-Change-Number: 31778 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Kevin Chiu (Code Review)

1:31 a.m.

New subject: Change in ...coreboot[master]: mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J S...

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31778 )

Change subject: mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................

Patch Set 3: -Code-Review

...

Patch Set 2:

Hi Kevin, If you want to remove the -1 and WIP from the commit message, I'll get this merged.

Hi Martin, done. Thank you!

-- To view, visit https://review.coreboot.org/c/coreboot/+/31778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Gerrit-Change-Number: 31778 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 07 Mar 2019 16:31:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

1:41 a.m.

New subject: Change in ...coreboot[master]: mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J S...

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31778 )

Change subject: mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................

mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants

BUG=b:127394249 BRANCH=master TEST=emerge-grunt coreboot chromeos-bootimage Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31778 Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc A src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16TB-062E-J.spd.hex 2 files changed, 34 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved

diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc b/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc index e6dc7e6..213fc05 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc +++ b/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc @@ -27,7 +27,7 @@ SPD_SOURCES += hynix-H5AN8G6NCJR-VKC # 0b1000 SPD_SOURCES += samsung-K4A8G165WC-BCTD # 0b1001 SPD_SOURCES += samsung-K4AAG165WB-MCTD # 0b1010 -SPD_SOURCES += empty # 0b1011 +SPD_SOURCES += micron-MT40A512M16TB-062E-J # 0b1011 SPD_SOURCES += empty # 0b1100 SPD_SOURCES += empty # 0b1101 SPD_SOURCES += empty # 0b1110 diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16TB-062E-J.spd.hex b/src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16TB-062E-J.spd.hex new file mode 100644 index 0000000..d4afea7 --- /dev/null +++ b/src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16TB-062E-J.spd.hex @@ -0,0 +1,33 @@ +# MT40A512M16TB-062E:J +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 05 0D F8 FF 2B 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 60 5B +0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 2C 00 00 00 00 00 00 00 4D 54 34 30 41 35 31 +32 4D 31 36 54 42 2D 30 36 32 45 3A 4A 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

-- To view, visit https://review.coreboot.org/c/coreboot/+/31778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff Gerrit-Change-Number: 31778 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2040

days inactive

2041

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

build bot (Jenkins) (Code Review)
Kevin Chiu (Code Review)
Martin Roth (Code Review)