Attention is currently required from: Jeff Daly, Subrata Banik, Mariusz Szafrański, Suresh Bellampalli, Paul Menzel, Vanessa Eusebio, Arthur Heymans.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63788 )
Change subject: cpu/intel/*: Set SMM SMRR code access check bit
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
Thanks Arthur!
File src/include/cpu/intel/smm_reloc.h:
https://review.coreboot.org/c/coreboot/+/63788/comment/65a6327d_d24d487e
PS4, Line 91: #define SMM_MCA_CAP_MSR 0x17d
: #define SMM_CODE_ACCESS_CHK_BIT 58
: #define SMM_CODE_ACESSS_CHK_MASK (1 << (SMM_CODE_ACCESS_CHK_BIT - 32))
:
: #define SMM_FEATURE_CONTROL_MSR 0x4e0
: #define SMM_FEATURE_CONTROL_LOCK (1 << 0)
: #define SMM_CODE_CHK_EN (1 << 2)
nit: align right side with tabs
https://review.coreboot.org/c/coreboot/+/63788/comment/dd5fae0e_1d568761
PS4, Line 105: }
still need the wrmsr(smm_feature) here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63788
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I254fb348483d2873917cf8c94c8b60e6f2d2c4e7
Gerrit-Change-Number: 63788
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 22 Apr 2022 16:09:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment