Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Martin Roth, Paul Menzel.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75574?usp=email )
Change subject: mb/google/myst: Add USB config
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75574/comment/d1d2d9dc_2a5eaf85 :
PS2, Line 9: FSP
In two years, nobody will remember and having to dig through Gerrit comments is going to be very tim […]
Nobody's going to care tomorrow. There will be a new FSP. It simply doesn't matter.
https://review.coreboot.org/c/coreboot/+/75574/comment/7c866719_b4fe538f :
PS2, Line 14: verify USB works
Maybe you can be more specific: verify hubs and attached USB devices are listed in `lsusb`
Really, it doesn't matter. USB wasn't working, now it does. It's fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75574?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I329aba80f3003a3a5f343b8dcc3efa8502b98e24
Gerrit-Change-Number: 75574
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sun, 04 Jun 2023 19:11:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Gerrit-MessageType: comment