Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48155 )
Change subject: soc/amd/picasso/aoac: fix type in comment ......................................................................
soc/amd/picasso/aoac: fix type in comment
the power_off_aoac_device function clears the FCH_AOAC_PWR_ON_DEV bit, so the comment should be that it powers off the devices.
Change-Id: Ia5e5d80b1977c3f53fcd9cf6d48bdb59045dfc3c Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/aoac.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/48155/1
diff --git a/src/soc/amd/picasso/aoac.c b/src/soc/amd/picasso/aoac.c index 1f7dcb0..f9fe0e2 100644 --- a/src/soc/amd/picasso/aoac.c +++ b/src/soc/amd/picasso/aoac.c @@ -45,7 +45,7 @@ { uint8_t byte;
- /* Power on the UART and AMBA devices */ + /* Power off the UART and AMBA devices */ byte = aoac_read8(AOAC_DEV_D3_CTL(dev)); byte &= ~FCH_AOAC_PWR_ON_DEV; aoac_write8(AOAC_DEV_D3_CTL(dev), byte);
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48155 )
Change subject: soc/amd/picasso/aoac: fix type in comment ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48155/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48155/1//COMMIT_MSG@7 PS1, Line 7: type typo
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48155
to look at the new patch set (#2).
Change subject: soc/amd/picasso/aoac: fix typo in comment ......................................................................
soc/amd/picasso/aoac: fix typo in comment
The power_off_aoac_device function clears the FCH_AOAC_PWR_ON_DEV bit, so the comment should be that it powers off the devices.
Change-Id: Ia5e5d80b1977c3f53fcd9cf6d48bdb59045dfc3c Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/aoac.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/48155/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48155 )
Change subject: soc/amd/picasso/aoac: fix typo in comment ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48155/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48155/1//COMMIT_MSG@7 PS1, Line 7: type
typo
oh, that that was a topo too. done.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48155 )
Change subject: soc/amd/picasso/aoac: fix typo in comment ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48155/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48155/1//COMMIT_MSG@7 PS1, Line 7: type
oh, that that was a topo too. done.
A demonstration
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48155 )
Change subject: soc/amd/picasso/aoac: fix typo in comment ......................................................................
soc/amd/picasso/aoac: fix typo in comment
The power_off_aoac_device function clears the FCH_AOAC_PWR_ON_DEV bit, so the comment should be that it powers off the devices.
Change-Id: Ia5e5d80b1977c3f53fcd9cf6d48bdb59045dfc3c Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48155 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/picasso/aoac.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/picasso/aoac.c b/src/soc/amd/picasso/aoac.c index 1f7dcb0..f9fe0e2 100644 --- a/src/soc/amd/picasso/aoac.c +++ b/src/soc/amd/picasso/aoac.c @@ -45,7 +45,7 @@ { uint8_t byte;
- /* Power on the UART and AMBA devices */ + /* Power off the UART and AMBA devices */ byte = aoac_read8(AOAC_DEV_D3_CTL(dev)); byte &= ~FCH_AOAC_PWR_ON_DEV; aoac_write8(AOAC_DEV_D3_CTL(dev), byte);
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)