Attention is currently required from: Taniya Das, Venkat Thogaru, Paul Menzel, Julius Werner, Sudheer Amrabadi.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs
......................................................................
Patch Set 11:
(1 comment)
File src/soc/qualcomm/sc7280/socinfo.c:
https://review.coreboot.org/c/coreboot/+/68384/comment/d9508b2b_ca817b58
PS4, Line 12: static struct chipinfo chipinfolut[] = {
So which one is it, future purpose or readability? […]
Qualcomm, do you have an update on this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68384
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca
Gerrit-Change-Number: 68384
Gerrit-PatchSet: 11
Gerrit-Owner: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
quic_tdas@quicinc.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Taniya Das
tdas@qualcomm.corp-partner.google.com
Gerrit-CC: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-Attention: Taniya Das
quic_tdas@quicinc.com
Gerrit-Attention: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Taniya Das
tdas@qualcomm.corp-partner.google.com
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Comment-Date: Fri, 04 Nov 2022 17:44:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Taniya Das
tdas@qualcomm.corp-partner.google.com
Gerrit-MessageType: comment