Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Martin Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75574?usp=email )
Change subject: mb/google/myst: Add USB config
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75574/comment/07f43f48_f4f4fa55 :
PS2, Line 9: FSP
In two years, nobody will remember and having to dig through Gerrit comments is going to be very time-consuming. I think,
… since early-bringup FSP …
would be helpful.
https://review.coreboot.org/c/coreboot/+/75574/comment/5b106c93_88896838 :
PS2, Line 14: verify USB works
We're still in early bringup. This enables testing. […]
Maybe you can be more specific: verify hubs and attached USB devices are listed in `lsusb`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75574?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I329aba80f3003a3a5f343b8dcc3efa8502b98e24
Gerrit-Change-Number: 75574
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 02 Jun 2023 15:04:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment