Attention is currently required from: Arthur Heymans, Philipp Hug, Ron Minnich.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83098?usp=email )
Change subject: arch/riscv: Factor out common romstage code
......................................................................
Patch Set 4:
(1 comment)
File src/arch/riscv/romstage.c:
https://review.coreboot.org/c/coreboot/+/83098/comment/e670647d_1d8bbea5?usp... :
PS2, Line 10: _weak void platform_romstage_main(void) { /* no-op, for bring-up */ }
Would it not be better if bring-up code explicitly adds an empty function rather than putting a weak […]
I don't really care, but I am not sure how common it is to not have one. I guess usually only emulation targets have that case.
Ok then I changed it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83098?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb11d2644bf42dacf89ef15b2ec51286fe729d64
Gerrit-Change-Number: 83098
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 01 Jul 2024 11:55:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz