Attention is currently required from: Maulik V Vaghela, Ravishankar Sarawadi, Tim Wawrzynczak, Reka Norman, Nick Vaccaro, Balaji Manigandan, Raj Astekar, Patrick Rudolph, Karthik Ramasubramanian.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52731 )
Change subject: soc/common/smbus: Add support for reading spd data via smbus for DDR5
......................................................................
Patch Set 8:
(3 comments)
File src/include/spd_bin.h:
https://review.coreboot.org/c/coreboot/+/52731/comment/e38e7915_722cc9cf
PS7, Line 42:
nit: extra space
Done
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/52731/comment/4eda481d_7e0f34e7
PS7, Line 55:
Can we add a comment here about the hub addressing, e,g. […]
Done
https://review.coreboot.org/c/coreboot/+/52731/comment/49bc2cd6_cb99f992
PS7, Line 100: const struct spd_offset_table *tbl;
: const struct spd_offset_table *table_select;
: u32 byte;
: u32 stop;
: u8 page;
:
: page = (u8) (~0);
: table_select = (struct spd_offset_table *)spd_ddr5_table;
: stop = ARRAY_SIZE(spd_ddr5_table)
I think these make more sense declared in the `is_spd5_hub` if scope as they are specific to that ca […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52731
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e6c58f255bef86b68ce90a4f853bf4e7c7ccfe
Gerrit-Change-Number: 52731
Gerrit-PatchSet: 8
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 11:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment