Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49208 )
Change subject: cpu/x86/smm: Use append instead of assign for smm-c-deps ......................................................................
cpu/x86/smm: Use append instead of assign for smm-c-deps
This change uses append operation (+=) instead of assignment (:=) for smm-c-deps to ensure that any earlier assignment is not overwritten.
Change-Id: Ic1d62b414cfe3f61ee2b80b026b7338faa186904 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/cpu/x86/smm/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/49208/1
diff --git a/src/cpu/x86/smm/Makefile.inc b/src/cpu/x86/smm/Makefile.inc index eb386a6..1ed018d 100644 --- a/src/cpu/x86/smm/Makefile.inc +++ b/src/cpu/x86/smm/Makefile.inc @@ -17,7 +17,7 @@
smmstub-generic-ccopts += -D__SMM__ smm-generic-ccopts += -D__SMM__ -smm-c-deps:=$$(OPTION_TABLE_H) +smm-c-deps+=$$(OPTION_TABLE_H)
$(obj)/smm/smm.o: $$(smm-objs) $(COMPILER_RT_smm) $(LD_smm) -nostdlib -r -o $@ $(COMPILER_RT_FLAGS_smm) --whole-archive --start-group $(filter-out %.ld, $(smm-objs)) --no-whole-archive $(COMPILER_RT_smm) --end-group
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49208 )
Change subject: cpu/x86/smm: Use append instead of assign for smm-c-deps ......................................................................
Patch Set 1: Code-Review+1
Attention is currently required from: Furquan Shaikh. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49208 )
Change subject: cpu/x86/smm: Use append instead of assign for smm-c-deps ......................................................................
Patch Set 1: Code-Review+2
Attention is currently required from: Furquan Shaikh. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49208 )
Change subject: cpu/x86/smm: Use append instead of assign for smm-c-deps ......................................................................
Patch Set 1: Code-Review+2
Attention is currently required from: Furquan Shaikh. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49208 )
Change subject: cpu/x86/smm: Use append instead of assign for smm-c-deps ......................................................................
Patch Set 1: Code-Review+2
Attention is currently required from: Furquan Shaikh. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49208 )
Change subject: cpu/x86/smm: Use append instead of assign for smm-c-deps ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49208 )
Change subject: cpu/x86/smm: Use append instead of assign for smm-c-deps ......................................................................
cpu/x86/smm: Use append instead of assign for smm-c-deps
This change uses append operation (+=) instead of assignment (:=) for smm-c-deps to ensure that any earlier assignment is not overwritten.
Change-Id: Ic1d62b414cfe3f61ee2b80b026b7338faa186904 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49208 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/cpu/x86/smm/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/cpu/x86/smm/Makefile.inc b/src/cpu/x86/smm/Makefile.inc index eb386a6..1ed018d 100644 --- a/src/cpu/x86/smm/Makefile.inc +++ b/src/cpu/x86/smm/Makefile.inc @@ -17,7 +17,7 @@
smmstub-generic-ccopts += -D__SMM__ smm-generic-ccopts += -D__SMM__ -smm-c-deps:=$$(OPTION_TABLE_H) +smm-c-deps+=$$(OPTION_TABLE_H)
$(obj)/smm/smm.o: $$(smm-objs) $(COMPILER_RT_smm) $(LD_smm) -nostdlib -r -o $@ $(COMPILER_RT_FLAGS_smm) --whole-archive --start-group $(filter-out %.ld, $(smm-objs)) --no-whole-archive $(COMPILER_RT_smm) --end-group
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Furquan Shaikh (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)