Attention is currently required from: Arthur Heymans, Julius Werner, Lance Zhao, Lean Sheng Tan, Maximilian Brune, Nico Huber, Paul Menzel, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76071?usp=email )
Change subject: arch/arm64: Hook up ACPI table generation
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/76071/comment/5cd29575_5f4e46a6 :
PS6, Line 78: config MAX_ACPI_TABLE_SIZE_KB
This is sort of missing 'depends on HAVE_ACPI_TABLES' but we probably should group most of the file under a single 'if HAVE_ACPI_TABLES' anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76071?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f60c546ec262ffb4d447fe6476844cf5a1b756d
Gerrit-Change-Number: 76071
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 02 Aug 2023 07:48:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment