Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41816 )
Change subject: soc/amd/picasso: add psp_verstage
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/chip.h
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/chip.h@...
PS9, Line 15: #include <arch/x86/include/arch/smp/mpspec.h> /* point from top level */
Then guard it with ENV_X86. It's only used by static. […]
That doesn't work either - static.c is compiled into verstage by default.
If I remove static.c from verstage, then device_const.c doesn't compile.
Some options that should work:
1) create the arch/smp/mpspec.h in the psp_verstage/include directory with just the definitions we need?
2) update the code in chip.h to something like:
#if ENV_X86
#include <arch/smp/mpspec.h>
#else
#define MP_IRQ_TRIGGER_LEVEL
#define MP_IRQ_POLARITY_HIGH
#endif
Thoughts?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia58839caa5bfbae0408702ee8d02ef482f2861c4
Gerrit-Change-Number: 41816
Gerrit-PatchSet: 9
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 22:51:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment