Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83922?usp=email )
Change subject: soc/mediatek/mt8196: Add GPIO driver ......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/mt8196/gpio.c:
https://review.coreboot.org/c/coreboot/+/83922/comment/cfeaa4cf_0ea805e7?usp... : PS6, Line 391: const struct gpio_drv_info *get_gpio_driving_info(uint32_t raw_id) : { : if (raw_id >= ARRAY_SIZE(gpio_driving_info)) { : printk(BIOS_ERR, "Error: raw_id is out of range\n"); : return NULL; : } : return &gpio_driving_info[raw_id]; : } : : const struct gpio_drv_info *get_gpio_driving_adv_info(uint32_t raw_id) : { : if (raw_id >= ARRAY_SIZE(gpio_driving_adv_info)) { : printk(BIOS_ERR, "Error: raw_id is out of range\n"); : return NULL; : } : return &gpio_driving_adv_info[raw_id]; : } These two functions mainly serve the callers in `src/soc/mediatek/common/gpio.c`. Add the log to the call sites. Otherwise, every SoC-specific implementation needs to add the duplicate logs, too.