Change in coreboot[master]: cpu/intel/common: Add support for energy performance preference (EPP)
Attention is currently required from: Cliff Huang, Selma Bensaid, Tim Wawrzynczak, Patrick Rudolph. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62653 )
Change subject: cpu/intel/common: Add support for energy performance preference (EPP) ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62653/comment/8955c816_0644515e PS1, Line 7: src/cpu/intel/common
`cpu/intel/common`
Done
https://review.coreboot.org/c/coreboot/+/62653/comment/4012d27a_dd9f6736 PS1, Line 12: BRANCH=firmware : BRANCH=firmware-brya-14505.Bre-brya-14505.B
`BRANCH=firmware-brya-14505. […]
Done
File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/62653/comment/e0be99de_dfdfbac8 PS1, Line 12: #define CPUID_6_ENGERY_PERF_PREF (1<<10) : #define CPUID_6_HWP (1<<7)
nit: make sure these all line up on the right side
Done
https://review.coreboot.org/c/coreboot/+/62653/comment/1d9958b9_2866180d PS1, Line 212: HWP_ENABLE
maybe a more informative message here, e.g. […]
Done
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/62653/comment/cf740f9a_721c9e92 PS1, Line 88: #define IA32_PM_ENABLE 0x770 : #define HWP_ENABLE 0x1 : #define IA32_HWP_CAPABILITIES 0x771 : #define IA32_HWP_REQUEST 0x774 : #define IA32_HWP_REQUEST_EPP_MASK 0xff000000 : #define IA32_HWP_REQUEST_EPP_SHIFT 24
nit: make sure these all line up on the right side
Done
-
Cliff Huang (Code Review)