[S] Change in coreboot[master]: soc/intel/common/tcss: Configure USB-C ports with attached devices

[Kapil Porwal (Code Review)]

Attention is currently required from: Eric Lai, John Su, John Zhao, Matt DeVillier, Subrata Banik.

Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72909?usp=email )

Change subject: soc/intel/common/tcss: Configure USB-C ports with attached devices
......................................................................

Patch Set 4:

(2 comments)

File src/soc/intel/common/block/tcss/tcss.c:

https://review.coreboot.org/c/coreboot/+/72909/comment/8eedc8a7_614b721e :
PS4, Line 357: 		if ((ret < 0) || !mux_info.usb)
could you please change it as below 
`		if ((ret < 0) || !mux_info.usb || (mux_info.dp && mux_info.hpd_lvl))`

https://review.coreboot.org/c/coreboot/+/72909/comment/4b46b617_d354e226 :
PS4, Line 361: 		ret = send_pmc_connect_request(i, &mux_info, port_info);
> I'm afraid that we might end up sending the PMC connect cmd twice if DP=1 and USB=1 for the same por […]

Correct. The current code will try to send the PMC CONN command for a DP+USB device as well but since we have already sent the PMC CONN command for all DP devices in `tcss_configure_dp_mode`, the second CONN command will be rejected by PMC. You can see below error messages in the logs -
```
[DEBUG]  port C1 CONN req: usage 0 usb3 3 usb2 1 ufp 0 ori_hsl 1 ori_sbu 1 dbg_acc 0
[DEBUG]  Raw Buffer output 0 00006130
[DEBUG]  Raw Buffer output 1 00000000
[ERROR]  pmc_send_ipc_cmd status: fatal
[ERROR]  Port 1 connect request failed
```

You can filter DP devices in this function to avoid the error.