Attention is currently required from: Hung-Te Lin, Knox Chiou, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email )
Change subject: mb/google/rauru: Implement SKU ID ......................................................................
Patch Set 8:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85666/comment/f960289e_361d41c9?usp... : PS7, Line 9: Geralt
Rauru
Done
File src/mainboard/google/rauru/boardid.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/4a74c103_d71fc87e?usp... : PS7, Line 38: printk(BIOS_DEBUG, "AUXADC: channel=%u\n", channel); : printk(BIOS_DEBUG, "AUXADC: VIN1=%d VIN2=%d\n", AUXADC_CHAN_VIN1, AUXADC_CHAN_VIN2);
These 2 logs don't seem needed.
Done
https://review.coreboot.org/c/coreboot/+/85666/comment/c956dc7c_b1fb7732?usp... : PS7, Line 41: printk(BIOS_DEBUG, "AUXADC: value=%d\n", value);
Don't need this either. We already print `value` in the other log below.
Done
https://review.coreboot.org/c/coreboot/+/85666/comment/75862ee0_96b0003f?usp... : PS7, Line 65: (get_adc_index(SKU_ID_HIGH_CHANNEL) << 4
We don't use VIN2 for neither Rauru nor Navi
Done
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/7a5a57b6_582b0e79?usp... : PS7, Line 59: configure_audio();
Need `mt6363_init_pmif_arb`.
Done