Attention is currently required from: Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63659 )
Change subject: mb/google/nipperkin: Remove EC_ENABLE_MKBP_DEVICE ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/variants/dewatt/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/63659/comment/aba81eb8_10d4b9f5 PS1, Line 5: /* Enable MKBP for buttons and switches */ : #define EC_ENABLE_MKBP_DEVICE : : /* Enable Tablet switch */ : #define EC_ENABLE_TBMC_DEVICE
I am not sure if they go well together. […]
We need either this enabled in coreboot or the CONFIG_TABLET_MODE_SWITCH enabled in EC. Enabling in EC is probably simpler. https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3589052