Attention is currently required from: Paul Menzel. Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62852 )
Change subject: mb/google/brask/variants/moli: update overridetree ......................................................................
Patch Set 27:
(5 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/62852/comment/0b1d7a91_634664eb PS19, Line 7: for moli
Remove, as it’s already part of the prefix.
done
https://review.coreboot.org/c/coreboot/+/62852/comment/96be02d3_11d53770 PS19, Line 9: adl_rfq_mb_20220310
That is the name of the schematic?
The name is adl_rfq_mb_20220310.pdf,i modified it.
https://review.coreboot.org/c/coreboot/+/62852/comment/fd899e00_f4e5eddc PS19, Line 10: 1.Enable HDMI2 in PortA, HDMI1 in PortB, HDMI/DP in tcp2. : 2.Disable USB2_Type-A Port A2, USB2_Type-A Port A9, TCP3. : 3.add USBC Port2. : 4.update ACPI_PLD_GROUP configure. : 5.Enable TPM in i2c1
Please add a space after the item number, and consistently start with a capital letter and remove th […]
done
File src/mainboard/google/brya/variants/moli/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62852/comment/fce459c6_b954f7b0 PS19, Line 9: # Enable HDMI2 in PortA,HDMI1 in PortB,HDMI/DP in tcp2
Please add a space after each comma.
done
https://review.coreboot.org/c/coreboot/+/62852/comment/7bc0a7d9_1cc5233f PS19, Line 18: register "tcss_ports[2]" = "TCSS_PORT_EMPTY " #Disable TCP3
Please add a space after the #.
done
-
Raihow Shi (Code Review)