Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42240 )
Change subject: soc/intel/xeon_sp: use edk2-stable202005 ......................................................................
soc/intel/xeon_sp: use edk2-stable202005
Use edk2-stable202005 header files instead of UDK2017 header files, since FSP uses latest EDK2 code base.
TESTED=Booted OCP Delta Lake server to OS.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I3c845bceb201d4ffdf5adbf2af9aad6d6794a19d --- M src/soc/intel/xeon_sp/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42240/1
diff --git a/src/soc/intel/xeon_sp/Kconfig b/src/soc/intel/xeon_sp/Kconfig index 8e39b77..ea48ff9 100644 --- a/src/soc/intel/xeon_sp/Kconfig +++ b/src/soc/intel/xeon_sp/Kconfig @@ -68,7 +68,7 @@ def_bool y depends on MAINBOARD_USES_FSP2_0 select PLATFORM_USES_FSP2_0 - select UDK_2017_BINDING + select UDK_202005_BINDING select POSTCAR_CONSOLE select POSTCAR_STAGE
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42240 )
Change subject: soc/intel/xeon_sp: use edk2-stable202005 ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42240/1/src/soc/intel/xeon_sp/Kconf... File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/42240/1/src/soc/intel/xeon_sp/Kconf... PS1, Line 71: UDK_202005_BINDING can you please point me the CL where this Kconfig has included ?
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42240 )
Change subject: soc/intel/xeon_sp: use edk2-stable202005 ......................................................................
Patch Set 2: Code-Review+2
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42240 )
Change subject: soc/intel/xeon_sp: use edk2-stable202005 ......................................................................
Patch Set 2:
(1 comment)
Thanks!
https://review.coreboot.org/c/coreboot/+/42240/1/src/soc/intel/xeon_sp/Kconf... File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/42240/1/src/soc/intel/xeon_sp/Kconf... PS1, Line 71: UDK_202005_BINDING
can you please point me the CL where this Kconfig has included ?
It is [CB:42239]. That change involves 569 files, so the default form of gerrit tool does not show it up. The Kconfig chagnes are at the bottom of the list when the file list is expanded: M src/vendorcode/intel/Kconfig M src/vendorcode/intel/Makefile.inc
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42240 )
Change subject: soc/intel/xeon_sp: use edk2-stable202005 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42240/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42240/2//COMMIT_MSG@7 PS2, Line 7: soc/intel/xeon_sp: use edk2-stable202005 … headers
https://review.coreboot.org/c/coreboot/+/42240/2//COMMIT_MSG@10 PS2, Line 10: since FSP uses latest EDK2 code base. What problem does this fix?
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42240 )
Change subject: soc/intel/xeon_sp: use edk2-stable202005 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42240/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42240/2//COMMIT_MSG@7 PS2, Line 7: soc/intel/xeon_sp: use edk2-stable202005
… headers
Done
https://review.coreboot.org/c/coreboot/+/42240/2//COMMIT_MSG@10 PS2, Line 10: since FSP uses latest EDK2 code base.
What problem does this fix?
It does not fix any known problem. That being said, since the latest EDK header files are from 2017 release, it is 3 years older than what the CPX-SP FSP binary depends on. It is better to be proactive to prevent hard to debug issues from popping up.
Hello build bot (Jenkins), Subrata Banik, Patrick Georgi, Subrata Banik, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42240
to look at the new patch set (#3).
Change subject: soc/intel/xeon_sp: use edk2-stable202005 headers ......................................................................
soc/intel/xeon_sp: use edk2-stable202005 headers
Use edk2-stable202005 header files instead of UDK2017 header files, since FSP uses latest EDK2 code base.
TESTED=Booted OCP Delta Lake server to OS.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I3c845bceb201d4ffdf5adbf2af9aad6d6794a19d --- M src/soc/intel/xeon_sp/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42240/3
Hello build bot (Jenkins), Subrata Banik, Patrick Georgi, Subrata Banik, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42240
to look at the new patch set (#4).
Change subject: soc/intel/xeon_sp: use edk2-stable202005 headers ......................................................................
soc/intel/xeon_sp: use edk2-stable202005 headers
Use edk2-stable202005 header files instead of UDK2017 header files, since FSP uses latest EDK2 code base.
TESTED=Booted OCP Delta Lake server to OS.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I3c845bceb201d4ffdf5adbf2af9aad6d6794a19d --- M src/soc/intel/xeon_sp/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42240/4
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42240 )
Change subject: soc/intel/xeon_sp: use edk2-stable202005 headers ......................................................................
soc/intel/xeon_sp: use edk2-stable202005 headers
Use edk2-stable202005 header files instead of UDK2017 header files, since FSP uses latest EDK2 code base.
TESTED=Booted OCP Delta Lake server to OS.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I3c845bceb201d4ffdf5adbf2af9aad6d6794a19d Reviewed-on: https://review.coreboot.org/c/coreboot/+/42240 Reviewed-by: Subrata Banik subrata.banik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/xeon_sp/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/xeon_sp/Kconfig b/src/soc/intel/xeon_sp/Kconfig index 9542562..8a9bf1e 100644 --- a/src/soc/intel/xeon_sp/Kconfig +++ b/src/soc/intel/xeon_sp/Kconfig @@ -68,7 +68,7 @@ def_bool y depends on MAINBOARD_USES_FSP2_0 select PLATFORM_USES_FSP2_0 - select UDK_2017_BINDING + select UDK_202005_BINDING select POSTCAR_CONSOLE select POSTCAR_STAGE
-
Jonathan Zhang (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)