Attention is currently required from: Terry Cheong, Vamshi Krishna Gopal.
Paul Menzel has posted comments on this change by Terry Cheong. ( https://review.coreboot.org/c/coreboot/+/82794?usp=email )
Change subject: mb/google/brox: Update verb table to refine speaker amp DC offset ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82794/comment/46496381_00648b3f?usp... : PS2, Line 9: DC offset of class-D amplifier is larger than expectation in Brox. Please add concrete values.
https://review.coreboot.org/c/coreboot/+/82794/comment/fe165b78_9d70d6f5?usp... : PS2, Line 10: based : on the updated verb table provided by Realtek Is that a comment in the bug report?
https://review.coreboot.org/c/coreboot/+/82794/comment/e5eef5eb_b199aafd?usp... : PS2, Line 15: TEST=Verify DC offset of speaker amplier is less than 3mV How? And what value did you measure?