Attention is currently required from: Henry Sun, Marco Chen, Zhuohao Lee, Karthik Ramasubramanian.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58734 )
Change subject: mb/google/dedede/var/galtic: update Wifi SAR for convertibles
......................................................................
Patch Set 7:
(4 comments)
File src/mainboard/google/dedede/variants/galtic/variant.c:
https://review.coreboot.org/c/coreboot/+/58734/comment/c8efe51f_39375580
PS6, Line 23: return "wifi_sar-galtic.hex";
Oh, just because in original code, galtic was returned so I think the default one would be galtic. […]
Done
https://review.coreboot.org/c/coreboot/+/58734/comment/1d52edd1_4d13e874
PS6, Line 27: galith
As you mentioned, if galith is the default SAR table defined in CL:3267913 then you can just have li […]
Done
https://review.coreboot.org/c/coreboot/+/58734/comment/21a73822_dfc4142b
PS6, Line 31: return "wifi_sar-galith360.hex";
nit: a new line before line 32 please.
Done
https://review.coreboot.org/c/coreboot/+/58734/comment/f5644477_415c99aa
PS6, Line 32: return "WIFI_SAR_CBFS_DEFAULT_FILENAME";
sorry, web page modification ignored
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4203d176dd717fa62c88d9b4fab8a53847213fe
Gerrit-Change-Number: 58734
Gerrit-PatchSet: 7
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 09 Nov 2021 02:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun
henrysun@google.com
Comment-In-Reply-To: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment